Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow conf vars within account block #790

Merged
merged 1 commit into from Nov 4, 2018
Merged

Allow conf vars within account block #790

merged 1 commit into from Nov 4, 2018

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Nov 2, 2018

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

/cc @nats-io/core

Signed-off-by: Waldemar Quevedo wally@synadia.com

@coveralls
Copy link

coveralls commented Nov 2, 2018 •
edited

Coverage Status

Coverage increased (+0.1%) to 91.084% when pulling 61d1ec5 on allow-conf-var-in-accounts-block into 2e579b8 on master.

derekcollison
derekcollison approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

server/config_check_test.go Outdated
deny = ["quux"]
}
subscribe = {
allow = [">"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is non-sensical.

server/config_check_test.go Outdated
{
name: "when accounts has a referenced config variables within same block",
config: `
accounts {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe indent since parser does not care to clean up test code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated the indentation for these.

@wallyqs
Allow conf vars within account block
61d1ec5 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@wallyqs wallyqs force-pushed the allow-conf-var-in-accounts-block branch from 851086d to 61d1ec5 Compare November 2, 2018 21:42
@derekcollison
Copy link
Member

LGTM

@derekcollison derekcollison merged commit 0d13c90 into master Nov 4, 2018
@derekcollison derekcollison deleted the allow-conf-var-in-accounts-block branch November 4, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @coveralls @derekcollison