Update to LameDuck mode #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase grace period to 10sec - Make default 2min - Reject config with value less than 30sec - Don't wait more than 1sec between clients if there are much less than alloted time - Stop after last one (was still sleeping after last client was closed) Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
| @@ -479,6 +479,11 @@ func (o *Options) ProcessConfigFile(configFile string) error { | |||
| errors = append(errors, err) | |||
| continue | |||
| } | |||
| if dur < 30*time.Second { | |||
| err := &configErr{tk, fmt.Sprintf("invalid lame_duck_duration of %v, minimum is 30 seconds", dur)} | |||
There was a problem hiding this comment.
We could probably do 1 sec if we have time, and hence exit early if we have small number of clients.
So LB = 60 sec. Grace = 10secs. So 50Sec window, if NumClients < 50, Close 1 every second. Then exit when NumClients == 0.
There was a problem hiding this comment.
I do max the sleep to ~1sec in this PR per client, so will exit early. What I don't do, is reduce the total time by the grace period. Should I?
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less than alloted time
closed)
Signed-off-by: Ivan Kozlovic ivan@synadia.com
/cc @nats-io/core