Changes to prevent fan-in scenarios from slow consumer state #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
requested changes
Jan 11, 2019
server/client.go
Outdated
| wdl time.Duration // Snapshot fo write deadline. | ||
| mp int64 // snapshot of max pending. | ||
| fsp int // Flush signals that are pending from readLoop's pcd. | ||
| lws int64 // Last write size |
There was a problem hiding this comment.
Not sure if this was during dev because I see it being set but not used anywhere?
There was a problem hiding this comment.
I was using it to determine releaseLock state but got more consistent results with what is there. I can remove.
wallyqs
reviewed
Jan 11, 2019
| // Do NOT hold lock during actual IO unless we are behind | ||
| if releaseLock { | ||
| c.mu.Unlock() | ||
| } |
There was a problem hiding this comment.
Can't reproduce the slow consumer issue with this change now (tried with nats-bench -np 40 -ns 1 -n 100000000 -ms 1024 foo)
There was a problem hiding this comment.
Yes I was using the new fan in tests but glad you tried this one too. Thanks!
wallyqs
approved these changes
Jan 11, 2019
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to balance the new decoupled producer consumer architecture for fanout with the ability to utilized coupled feedback in fan in scenarios where slow consumers where becoming the norm.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core