enhance ut for server #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Jan 17, 2019
server/util_test.go
Outdated
|
|
||
| n = []byte("12345invalid678") | ||
| if pn := parseSize(n); pn != -1 { | ||
| t.Fatalf("Should error on %q, res=%d\n", n, pn) |
There was a problem hiding this comment.
You don't need the \n at the end. Same for the other that you added. I know that it is in the existing test code but we try not to add them in new code.
server/util_test.go
Outdated
|
|
||
| n = []byte("12345invalid678") | ||
| if pn := parseInt64(n); pn != -1 { | ||
| t.Fatalf("Should error on %q, res=%d\n", n, pn) |
There was a problem hiding this comment.
Remove \n on t.Fatalf and we should be good.
derekcollison
requested changes
Jan 17, 2019
|
@derekcollison Done. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
TestParseSizeandTestParseSInt64/cc @nats-io/core