Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangling bracket and parens EOF bugs in config parser #887

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Fix dangling bracket and parens EOF bugs in config parser #887

merged 1 commit into from
Jan 29, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jan 29, 2019

Signed-off-by: Waldemar Quevedo wally@synadia.com

  • Tests added
  • Branch rebased on top of current master (git pull --rebase origin master)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Fixes #886

/cc @nats-io/core

@wallyqs
Fix dangling bracket and parens eof bugs in config parser
c3a441f 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
derekcollison
derekcollison approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 75a489a into nats-io:master Jan 29, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.878% when pulling c3a441f on wallyqs:config-parser-bugs into ed94bd9 on nats-io:master.

@wallyqs wallyqs deleted the config-parser-bugs branch January 29, 2019 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @coveralls @derekcollison