Fixed possible race when looking/registering an account #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
approved these changes
Jan 31, 2019
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
force-pushed
the
fix_account_lookup_race
branch
from
53b5a4d
to
2e9fe69
Compare
kozlovic
added a commit
that referenced
this pull request
Nov 17, 2019
- Risk of deadlock when checking if issuer claim are trusted. There was a RLock() in one thread, then a request for Lock() in another that was waiting for RLock() to return, but the first thread was then doing RLock() which was not acquired because this was blocked by the Lock() request (see golang/go@e2160cc) - Use proper account/locking mode when checking if stream/service exports/signer have changed. - Account registration race (regression from #890) - Move test from #890 to "no race" test since only then could it detect the double registration. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Kozlovic ivan@synadia.com