Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show parse errors from looked up env vars #892

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jan 31, 2019

Currently if there are issues parsing an env var, the config parser fails silently.

/cc @nats-io/core

Signed-off-by: Waldemar Quevedo wally@synadia.com

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@derekcollison
Copy link
Member

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 91.7% when pulling d0d0525 on wallyqs:lookup-env-errors into a4741c5 on nats-io:master.

@derekcollison derekcollison merged commit 09a4b05 into nats-io:master Feb 6, 2019
@wallyqs wallyqs deleted the lookup-env-errors branch February 6, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants