Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go import path for Travis #906

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Feb 14, 2019

This allows being able to run test builds when forking the repo.

Signed-off-by: Waldemar Quevedo wally@synadia.com

/cc @nats-io/core

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anybody with a Travis account or does this show up under our account and affect our builds?

@wallyqs
Copy link
Member Author

wallyqs commented Feb 14, 2019

It wouldn't show up under our builds, only under the Travis builds from the user of the forked repo, otherwise test fail because of path issues: https://travis-ci.org/wallyqs/gnatsd/builds

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 01016a2 into nats-io:master Feb 14, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.547% when pulling 2936e1b on wallyqs:travis-go-import-path into c329da7 on nats-io:master.

@wallyqs wallyqs deleted the travis-go-import-path branch February 18, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants