Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.12 to Travis #919

Merged
merged 1 commit into from Mar 7, 2019
Merged

Add Go 1.12 to Travis #919

merged 1 commit into from Mar 7, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Mar 6, 2019

Build is green in Travis CI ✅

/cc @nats-io/core

derekcollison
derekcollison reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to switch though to releases on 1.12 yet though?

@wallyqs
Copy link
Member Author

wallyqs commented Mar 6, 2019

Right, ok for releases will not bump to Go 1.12 yet

@wallyqs
Add Go 1.12 to the build
7da8861 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
derekcollison
derekcollison approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited

Coverage Status

Coverage decreased (-0.1%) to 91.392% when pulling 7da8861 on travis-updates into 0255390 on master.

@wallyqs wallyqs merged commit c625970 into master Mar 7, 2019
@wallyqs wallyqs deleted the travis-updates branch March 7, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @coveralls @derekcollison