Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow using quotes around include" #973

Merged
merged 1 commit into from Apr 26, 2019

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Apr 26, 2019

Reverts #891 since it would mean not being able to use "include": as part of map. Only way that another file can be included would be via this syntax:

include "path/to/file"

and all the following would result in unknown field "include" error:

include: "path/to/file"
"include": "path/to/file"
'include': "path/to/file"
"include" "path/to/file"
'include' "path/to/file"

/cc @nats-io/core

@wallyqs wallyqs requested a review from a team April 26, 2019 01:21
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 90.745% when pulling ff357d8 on revert-891-include-parsing-fixes into 2d0abd6 on master.

@derekcollison derekcollison merged commit 0e5472a into master Apr 26, 2019
@derekcollison derekcollison deleted the revert-891-include-parsing-fixes branch April 26, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants