Leafnode updates #980
Merged
Leafnode updates #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
kozlovic
approved these changes
May 2, 2019
server/leafnode.go
Outdated
| gws := gwsa[:0] | ||
| s.getOutboundGatewayConnections(&gws) | ||
| for _, cgw := range gws { | ||
| if ei, _ := cgw.gw.outsim.Load(accName); ei != nil { |
There was a problem hiding this comment.
I believe that we don't need indeed to cgw.mu.Lock()/Unlock() here since cgw.gw is set when the object is initialized and I don't think I ever set it to nil.
Same for accessing ei.(*outsie).sl.All() without checking if sl is nil or not. sl should be initialized when an entry is added in the map, at least in the "gateway-only" code path. Since we have now trigger some gateway code from leafnode conditions, I am not entirely sure that this is always the case.
There was a problem hiding this comment.
Will take a look. I can lock it down more.
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for panics in auth event handling and leafnodes.
Added gateway interest for smap handling for leafnodes.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core