Update Travis + Fixed flapping tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was getting failures with `-race` for heartbeat tests. The util function sendAndWait() just ensures that the heartbeat has been dequeued. Change in state and/or leader is not guaranteed at this point. Added waitForLeader and waitForState to wait for a certain amount of time for the expected leader/state. Used these in various places, may need to use it in some other places if we get other tests failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting failures with
-racefor heartbeat tests.The util function sendAndWait() just ensures that the heartbeat
has been dequeued. Change in state and/or leader is not guaranteed
at this point. Added waitForLeader and waitForState to wait for
a certain amount of time for the expected leader/state. Used these
in various places, may need to use it in some other places if we
get other tests failures.