Ensure StateChange are posted in order to Handler #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another approach for solving issue #11 that was addressed with PR #12. The advantage of this approach over #12 is that there will be atmost 1 go-routine per type of event (StateChange and error). Added a test that demonstrates that not receiving from state change and error channels do not block the Node. Also fixed a flapping test. Resolves #11
| @@ -7,7 +7,9 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "fmt" | |||
There was a problem hiding this comment.
sort these, all pkg ones at top and 3rd party separated by line space and at the bottom.
There was a problem hiding this comment.
Sorry about that. The IDE is integrated with go fmt, etc.. and usually orders correctly those. Not sure what happened.
| n.stateChg = append(n.stateChg, sc) | ||
| // Invoke postStateChange only for the first state change added. | ||
| // Check postStateChange for details. | ||
| if len(n.stateChg) == 1 { |
There was a problem hiding this comment.
Can this change again before you check the length?
There was a problem hiding this comment.
No it can't, we are under the node's lock when adding, checking and removing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another approach for solving issue #11 that was addressed
with PR #12. The advantage of this approach over #12 is that there
will be atmost 1 go-routine per type of event (StateChange and error).
Added a test that demonstrates that not receiving from state change
and error channels do not block the Node.
Also fixed a flapping test.
Resolves #11