Merge bda55e4 into 0b6d1dc

nats-io · Feb 12, 2020 · 0e2737e · 0e2737e
2 parents 0b6d1dc + bda55e4
commit 0e2737e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 38 deletions.
diff --git a/types.go b/types.go
@@ -241,8 +241,6 @@ type Permissions struct {
 
 // Validate the pub and sub fields in the permissions list
 func (p *Permissions) Validate(vr *ValidationResults) {
-	p.Pub.Validate(vr)
-	p.Sub.Validate(vr)
 	if p.Resp != nil {
 		p.Resp.Validate(vr)
 	}

diff --git a/user_claims_test.go b/user_claims_test.go
@@ -227,42 +227,6 @@ func TestUserValidation(t *testing.T) {
 	if vr.IsEmpty() || len(vr.Issues) != 1 || !vr.IsBlocking(true) {
 		t.Error("bad limit should be invalid")
 	}
-
-	uc.Limits.Times = []TimeRange{}
-	uc.Permissions.Pub.Allow.Add("bad subject")
-	vr = CreateValidationResults()
-	uc.Validate(vr)
-
-	if vr.IsEmpty() || len(vr.Issues) != 1 || !vr.IsBlocking(true) {
-		t.Error("bad permission should be invalid")
-	}
-
-	uc.Permissions.Pub.Allow.Remove("bad subject")
-	uc.Permissions.Sub.Allow.Add("bad subject")
-	vr = CreateValidationResults()
-	uc.Validate(vr)
-
-	if vr.IsEmpty() || len(vr.Issues) != 1 || !vr.IsBlocking(true) {
-		t.Error("bad permission should be invalid")
-	}
-
-	uc.Permissions.Sub.Allow.Remove("bad subject")
-	uc.Permissions.Pub.Deny.Add("bad subject")
-	vr = CreateValidationResults()
-	uc.Validate(vr)
-
-	if vr.IsEmpty() || len(vr.Issues) != 1 || !vr.IsBlocking(true) {
-		t.Error("bad permission should be invalid")
-	}
-
-	uc.Permissions.Pub.Deny.Remove("bad subject")
-	uc.Permissions.Sub.Deny.Add("bad subject")
-	vr = CreateValidationResults()
-	uc.Validate(vr)
-
-	if vr.IsEmpty() || len(vr.Issues) != 1 || !vr.IsBlocking(true) {
-		t.Error("bad permission should be invalid")
-	}
 }
 
 func TestUserAccountID(t *testing.T) {