Merge 787faf5 into 0c3fc7a

account_claims_test.go

@@ -228,7 +228,7 @@ func TestAccountImports(t *testing.T) {
 func TestNewNilAccountClaim(t *testing.T) {
 	v := NewAccountClaims("")
 	if v != nil {
-		t.Fatal(fmt.Sprintf("expected nil account claim"))
+		t.Fatal("expected nil account claim")
 	}
 }
 

activation_claims_test.go

@@ -136,7 +136,7 @@ func TestPublicIsNotValid(t *testing.T) {
 func TestNilActivationClaim(t *testing.T) {
 	v := NewActivationClaims("")
 	if v != nil {
-		t.Fatal(fmt.Sprintf("expected nil user claim"))
+		t.Fatal("expected nil activation claim")
 	}
 }
 

cluster_claims_test.go

@@ -113,7 +113,7 @@ func TestClusterSubjects(t *testing.T) {
 func TestNewNilClusterClaims(t *testing.T) {
 	v := NewClusterClaims("")
 	if v != nil {
-		t.Fatal(fmt.Sprintf("expected nil user claim"))
+		t.Fatal("expected nil cluster claim")
 	}
 }
 

exports.go

@@ -60,8 +60,8 @@ type ServiceLatency struct {
 }
 
 func (sl *ServiceLatency) Validate(vr *ValidationResults) {
-	if sl.Sampling < 1 || sl.Sampling > 100 {
-		vr.AddError("sampling percentage needs to be between 1-100")
+	if sl.Sampling < 0 || sl.Sampling > 100 {
+		vr.AddError("sampling percentage needs to be between 0-100")
 	}
 	sl.Results.Validate(vr)
 	if sl.Results.HasWildCards() {

exports_test.go

@@ -229,7 +229,7 @@ func TestExportRevocation(t *testing.T) {
 	e.RevokeAt(pubKey, now.Add(time.Second*1000))
 
 	if !e.IsRevoked(pubKey) {
-		t.Errorf("revocation be true we revoked in the future")
+		t.Error("revocation be true we revoked in the future")
 	}
 }
 
@@ -247,31 +247,39 @@ func TestExportTrackLatency(t *testing.T) {
 	vr = CreateValidationResults()
 	e.Validate(vr)
 	if vr.IsEmpty() {
-		t.Errorf("adding latency tracking to a stream should have an validation issue")
+		t.Error("adding latency tracking to a stream should have an validation issue")
 	}
 
 	e = &Export{Subject: "foo", Type: Service}
 	e.Latency = &ServiceLatency{Sampling: 0, Results: "results"}
 	vr = CreateValidationResults()
 	e.Validate(vr)
+	if !vr.IsEmpty() {
+		t.Fatal(vr.Issues[0])
+	}
+
+	e = &Export{Subject: "foo", Type: Service}
+	e.Latency = &ServiceLatency{Sampling: -1, Results: "results"}
+	vr = CreateValidationResults()
+	e.Validate(vr)
 	if vr.IsEmpty() {
-		t.Errorf("Sampling <1 should have a validation issue")
+		t.Error("Sampling < 0 should have a validation issue")
 	}
 
 	e = &Export{Subject: "foo", Type: Service}
 	e.Latency = &ServiceLatency{Sampling: 122, Results: "results"}
 	vr = CreateValidationResults()
 	e.Validate(vr)
 	if vr.IsEmpty() {
-		t.Errorf("Sampling >100 should have a validation issue")
+		t.Error("Sampling >100 should have a validation issue")
 	}
 
 	e = &Export{Subject: "foo", Type: Service}
 	e.Latency = &ServiceLatency{Sampling: 22, Results: "results.*"}
 	vr = CreateValidationResults()
 	e.Validate(vr)
 	if vr.IsEmpty() {
-		t.Errorf("Results subject needs to be valid publish subject")
+		t.Error("Results subject needs to be valid publish subject")
 	}
 }
 

header.go

@@ -23,7 +23,7 @@ import (
 
 const (
 	// Version is semantic version.
-	Version = "0.3.2"
+	Version = "0.3.4"
 
 	// TokenTypeJwt is the JWT token type supported JWT tokens
 	// encoded and decoded by this library

operator_claims_test.go

@@ -110,7 +110,7 @@ func TestInvalidOperatorClaimIssuer(t *testing.T) {
 func TestNewNilOperatorClaims(t *testing.T) {
 	v := NewOperatorClaims("")
 	if v != nil {
-		t.Fatal(fmt.Sprintf("expected nil user claim"))
+		t.Fatal("expected nil operator claim")
 	}
 }
 

server_claims_test.go

@@ -113,7 +113,7 @@ func TestServerSubjects(t *testing.T) {
 func TestNewNilServerClaims(t *testing.T) {
 	v := NewServerClaims("")
 	if v != nil {
-		t.Fatal(fmt.Sprintf("expected nil user claim"))
+		t.Fatal("expected nil server claim")
 	}
 }
 

user_claims_test.go

@@ -113,7 +113,7 @@ func TestUserSubjects(t *testing.T) {
 func TestNewNilUserClaim(t *testing.T) {
 	v := NewUserClaims("")
 	if v != nil {
-		t.Fatal(fmt.Sprintf("expected nil user claim"))
+		t.Fatal("expected nil user claim")
 	}
 }