Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] IsClaimRevoked to check user claim and fixed some comments. #108

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

kozlovic
Copy link
Member

Comment for RevokeAt(), IsRevokedAt() have been fixed.

The function IsRevoked() must no longer be used (and removed in v2).
It will now always return true. Use IsRevokedAt() instead with
proper timestamp.

This is a port of #103

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Comment for RevokeAt(), IsRevokedAt() have been fixed.

The function IsRevoked() must no longer be used (and removed in v2).
It will now always return `true`. Use IsRevokedAt() instead with
proper timestamp.

This is a port of #103

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 494

  • 3 of 8 (37.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 87.264%

Changes Missing Coverage Covered Lines Changed/Added Lines %
account_claims.go 3 8 37.5%
Totals Coverage Status
Change from base Build 492: -0.4%
Covered Lines: 1062
Relevant Lines: 1217

💛 - Coveralls

Copy link
Contributor

@matthiashanel matthiashanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 37b514b into branch_v1 Oct 20, 2020
@kozlovic kozlovic deleted the port_is_claim_revoked branch October 20, 2020 23:21
kozlovic added a commit that referenced this pull request Oct 28, 2020
Comment for RevokeAt(), IsRevokedAt() have been fixed.

The function IsRevoked() must no longer be used (and removed in v2).
It will now always return true. Use IsRevokedAt() instead with
proper timestamp.

Note: This was done in v2 and backported to branch_v1 but was not
added to the v1 in the main branch. So this is a port of #108.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants