Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signing keys to operator claims. #12

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Added signing keys to operator claims. #12

merged 3 commits into from
Nov 20, 2018

Conversation

sasbury
Copy link
Contributor

@sasbury sasbury commented Nov 20, 2018

No description provided.

@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 78

  • 24 of 28 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 90.099%

Changes Missing Coverage Covered Lines Changed/Added Lines %
operator_claims.go 24 28 85.71%
Totals Coverage Status
Change from base Build 72: 0.5%
Covered Lines: 819
Relevant Lines: 909

💛 - Coveralls

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a convenience function that says a JWT was signed by an operator or a signing key from the operator..

@sasbury
Copy link
Contributor Author

sasbury commented Nov 20, 2018

Let me add that.

return true
}

if s.SigningKeys == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this test, range works over nil.

@sasbury sasbury merged commit 17ee2e5 into master Nov 20, 2018
@sasbury sasbury deleted the signing_keys branch November 20, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants