Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding max_ack_pending stream limit #174

Merged
merged 3 commits into from Mar 30, 2022
Merged

Adding max_ack_pending stream limit #174

merged 3 commits into from Mar 30, 2022

Conversation

matthiashanel
Copy link
Contributor

Signed-off-by: Matthias Hanel mh@synadia.com

aricart
aricart approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (save for the build failure - possible fmt?)

@matthiashanel
Adding max_ack_pending stream limit
9928008 
Signed-off-by: Matthias Hanel <mh@synadia.com>
@matthiashanel
Use t.Fatalf(...) instead of t.Fatal(fmt.Sprintf(...))
c11dbed 
Signed-off-by: Matthias Hanel <mh@synadia.com>
@matthiashanel
Fix go 1.16 github actions staticcheck build issues
03a6fb2 
Signed-off-by: Matthias Hanel <mh@synadia.com>
wallyqs
wallyqs approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiashanel matthiashanel merged commit 442af02 into master Mar 30, 2022
@matthiashanel matthiashanel deleted the max-ack-pending branch March 30, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@aricart aricart aricart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiashanel @wallyqs @aricart