[ADDED] Sampling in MsgTrace structure #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an account has a `Trace` field set with a `Destination`, if an incoming message has a `traceparent` header with proper flag indicating that the message should be trace, the `Sampling` integer (value in the range of [1..100]) allows tracing only a random sample of messages. The server will pick a random number below 100 and if that number is lower or equal to this `Sampling` value then the trace will trigger. If above, the trace will not trigger. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Pull Request Test Coverage Report for Build 8007938917Details
💛 - Coveralls |
aricart
approved these changes
Feb 22, 2024
|
@aricart It was a wise choice to make it a struct, since as you can see we had to add something already ;-). Same deal than before though. Once review is complete and merged, could you issue a release? I have the server branch pointing to this to make sure that everything is ok, but once I have proper release, I will update the server branch and submit the PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account has a
Tracefield set with aDestination, if an incoming message has atraceparentheader with proper flag indicating that the message should be trace, theSamplinginteger (value in the range of [1..100]) allows tracing only a random sample of messages. The server will pick a random number below 100 and if that number is lower or equal to thisSamplingvalue then the trace will trigger. If above, the trace will not trigger.Signed-off-by: Ivan Kozlovic ivan@synadia.com