Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate base64 codec #22

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Isolate base64 codec #22

merged 3 commits into from
Dec 4, 2018

Conversation

sasbury
Copy link
Contributor

@sasbury sasbury commented Dec 4, 2018

Alberto's code to isolated the base 64 stuff + a test.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 113

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 90.721%
Totals Coverage Status
Change from base Build 108: 0.4%
Covered Lines: 831
Relevant Lines: 916
💛 - Coveralls

@aricart
Copy link
Member

aricart commented Dec 4, 2018

LGTM

@aricart aricart merged commit c75329a into master Dec 4, 2018
@aricart aricart deleted the isolate-base64-codec branch December 4, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison Awaiting requested review from derekcollison

@aricart aricart Awaiting requested review from aricart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sasbury @coveralls @aricart