[ADDED] Connection type "in process" #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `ConnectionTypeInProcess` to the `UserPermissionLimits.AllowedConnectionTypes` list of possible types. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@aricart As usual, doing this PR and once merged, would you mind doing a release? I have a server PR that will need to be updated to point to proper commit. |
Pull Request Test Coverage Report for Build 8995033103Details
💛 - Coveralls |
|
@aricart I am waiting on some feedback from the user on the NATS Server issue, so please hold off the review until I hear back. I will post here when ready for review. Switching to Draft to make sure there is no merge by mistake. |
|
@aricart Ok, I heard from the user and that will work. So you can review now. Thanks! |
|
Doing |
|
@aricart Let me know if you can do a release. If not, I will reference the commit from main first and update when the release will be available. |
This was referenced May 9, 2024
|
@kozlovic let me cut a release |
|
@kozlovic done!! |
|
@aricart Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ConnectionTypeInProcessto theUserPermissionLimits.AllowedConnectionTypeslist of possible types.Signed-off-by: Ivan Kozlovic ivan@synadia.com