Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for nolimit semantics. #23

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Updates for nolimit semantics. #23

merged 3 commits into from
Dec 5, 2018

Conversation

derekcollison
Copy link
Member

Made default accounts have no limits.
Added test for import limit violation.
Added ability to ask if limits are unlimited.

@derekcollison
Updates for nolimit semantics
4a1d069 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison
Add modules support
58d1756 
Signed-off-by: Derek Collison <derek@nats.io>
aricart
aricart approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison
Update nkeys dependency
7c71afa 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit db639cc into master Dec 5, 2018
@derekcollison derekcollison deleted the nolimit branch December 5, 2018 15:25
@coveralls
Copy link

coveralls commented Dec 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 120

  • 13 of 15 (86.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 90.605%
Changes Missing Coverage Covered Lines Changed/Added Lines %
account_claims.go 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
account_claims.go 1 94.87%
Totals Coverage Status
Change from base Build 114: -0.1%
Covered Lines: 839
Relevant Lines: 926
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

@sasbury sasbury Awaiting requested review from sasbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derekcollison @coveralls @aricart