Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed constraint on having multiple exports related to the same subject #24

Closed
wants to merge 1 commit into from
Closed

removed constraint on having multiple exports related to the same subject #24

wants to merge 1 commit into from

Conversation

aricart
Copy link
Member

@aricart aricart commented Dec 7, 2018

No description provided.

derekcollison
derekcollison requested changes Dec 7, 2018
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to complain if two exports same subject w/ same type. And for same type we still need check for contained within.

@aricart aricart closed this Dec 7, 2018
@aricart aricart deleted the remove-export-constraints branch December 7, 2018 15:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 125

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 90.133%
Files with Coverage Reduction New Missed Lines %
types.go 2 90.32%
Totals Coverage Status
Change from base Build 122: -0.5%
Covered Lines: 813
Relevant Lines: 902
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aricart @coveralls @derekcollison