relaxed contain rule so exports of different kinds can overlap in subjects #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exports.go
Outdated
| @@ -73,10 +66,28 @@ func (e *Exports) Validate(vr *ValidationResults) error { | |||
| for k, v := range m { | |||
| var vi ValidationIssue | |||
| vi.Blocking = true | |||
| vi.Description = fmt.Sprintf("export subject %q already exports %q", k, v) | |||
| vi.Description = fmt.Sprintf("%s export subject %q already exports %q", kind.String(), k, v) | |||
There was a problem hiding this comment.
If kind has a String(), don't need it with %s.
exports_test.go
Outdated
| @@ -61,7 +61,7 @@ func TestExportsValidation(t *testing.T) { | |||
| exports.Add(i, i2) | |||
|
|
|||
| vr := CreateValidationResults() | |||
| exports.Validate(vr) | |||
| _ = exports.Validate(vr) | |||
There was a problem hiding this comment.
remove assignment to nothing.
There was a problem hiding this comment.
some of my tools started complaining about 'unhandled errors'
exports_test.go
Outdated
| @@ -92,9 +92,54 @@ func TestOverlappingExports(t *testing.T) { | |||
| exports.Add(i, i2) | |||
|
|
|||
| vr := CreateValidationResults() | |||
| exports.Validate(vr) | |||
| _ = exports.Validate(vr) | |||
derekcollison
approved these changes
Dec 7, 2018
aricart
force-pushed
the
export-constraints
branch
from
03c6b79
to
7d21f9c
Compare
Pull Request Test Coverage Report for Build 127
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports of same kind will generate an error if their subjects overlap or are same
exports of different kind are allowed to overlap or match a different service type