Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted ExportType to enum #7

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Converted ExportType to enum #7

merged 1 commit into from
Nov 19, 2018

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Converted export type to enum
22685e9 
Signed-off-by: Derek Collison <derek@nats.io>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 58

  • 19 of 32 (59.38%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 90.034%
Changes Missing Coverage Covered Lines Changed/Added Lines %
types.go 15 28 53.57%
Totals Coverage Status
Change from base Build 56: -1.2%
Covered Lines: 795
Relevant Lines: 883
💛 - Coveralls

@aricart
Copy link
Member

aricart commented Nov 19, 2018

LGTM

@aricart aricart merged commit 78329ef into master Nov 19, 2018
@aricart aricart deleted the types branch November 19, 2018 17:30
aricart added a commit that referenced this pull request May 21, 2019
@aricart
FIX #7 - Added AccountServerURL to enable an operator to specify an…
08f5f2b 
… URL where a tool can POST/submit a JWT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart Awaiting requested review from aricart

@sasbury sasbury Awaiting requested review from sasbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derekcollison @coveralls @aricart