Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creds parsing on files that have had their line endings changed to CRLFs. #72

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

aricart
Copy link
Member

@aricart aricart commented Feb 21, 2020

FIX #71 - Relaxed regex to allow optional carriage returns. Target content also had to change from .+, to more specifically grab the non-whitespace content.

Note that this regex is fairly complicated, an alternative fix simply strips carriage returns from the input before parsing. I am OK with doing that change instead, as this required quite a bit of staring (with Matthias).

… had to change from `.+`, to more specifically grab the non-whitespace content.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.275%

Totals Coverage Status
Change from base Build 337: 0.0%
Covered Lines: 1054
Relevant Lines: 1194

💛 - Coveralls

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Be good to see more test cases with users adding different comments etc. Essentially as long as jwt and pk are valid we should be good.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@matthiashanel
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modified credential files with windows EOL chars not working
6 participants