Don't enable WebSocket compression by default #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are some problems where the flate writer might take up more allocations than expected when there are lots of WebSocket clients. Signed-off-by: Neil Twigg <neil@nats.io>
|
My original thought was that enabling compression by default was good for most common use cases, since Cloud Provider bandwidth is so expensive. But if the desire is to optimize for high performance scenarios on fast network connections, I digress. The tests that assert compression is on in the chart’s |
added 2 commits
June 18, 2024 10:36
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
caleblloyd
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are some problems where the flate writer might take up more allocations than expected when there are lots of WebSocket clients.
Signed-off-by: Neil Twigg neil@nats.io