Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS.ACK new tokens #49

Closed
10 tasks done
kozlovic opened this issue Aug 17, 2021 · 3 comments
Closed
10 tasks done

JS.ACK new tokens #49

kozlovic opened this issue Aug 17, 2021 · 3 comments
Assignees
@wallyqs
Labels
client Client related work enhancement New feature or request

Comments

@kozlovic
Copy link
Member

kozlovic commented Aug 17, 2021 •
edited by marthaCP

Overview

Newer servers will include possibly 2 tokens to the $JS.ACK. ack subject, a possible domain, and an always present "account hash". The library does not do anything with those, but need to take them into account in order to properly locate the tokens that it needs.

The behavior is documented in ADR-15, section: https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-15.md#js-ack

Clients and Tools

Other Tasks

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.
@kozlovic kozlovic added enhancement New feature or request client Client related work labels Aug 17, 2021
@ripienaar ripienaar removed their assignment Aug 18, 2021
This was referenced Aug 20, 2021
Closed
Closed
Merged
@spacejam spacejam mentioned this issue Aug 25, 2021
Merged
@scottf scottf removed their assignment Feb 17, 2022
@bruth bruth mentioned this issue Sep 10, 2022
Merged
@bruth
Copy link
Member

bruth commented Sep 10, 2022

Opened nats-io/nats.py#351 for Python support.

@bruth
Copy link
Member

bruth commented Sep 13, 2022

Docs PR nats-io/nats.docs#485

@bruth bruth mentioned this issue Sep 13, 2022
Closed
ColinSullivan1 added a commit that referenced this issue Oct 27, 2022
@ColinSullivan1
Mark ADR-15 as Implemented
58127f9 
Per #49, it looks like we can mark this as implemented and close out the issue.

Signed-off-by: Colin Sullivan <colin@synadia.com>
@ColinSullivan1 ColinSullivan1 mentioned this issue Oct 27, 2022
Open
@marthaCP
Copy link
Contributor

Colin updated ADR 15; All actions are complete as of 10/27/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wallyqs wallyqs

Labels
client Client related work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@wallyqs @ripienaar @scottf @bruth @aricart @spacejam @ColinSullivan1 @kozlovic @marthaCP