js simplification ADR #176
Conversation
aricart
requested review from
derekcollison,
Jarema,
piotrpio,
scottf and
tbeets
aricart
force-pushed
the
js-simplification
branch
from
7909d3e
to
ef20cd0
Compare
|
It would be nice to add in the part about the Consume payload not just being a message, but an object/tuple whatever |
This is language specific. |
Agreed the implementation is language specific. I'd just like to call it out specifically in the doc that the behavior is required. |
adr/ADR-32.md
Outdated
| - Every other pull request error should be treated as terminal error - it should be telegraphed to the user (in langie-specific way), | ||
| the `Consume()` execution should be stopped and subscription should be drained. | ||
|
|
||
| ###### Idle heartbeats |
There was a problem hiding this comment.
This seems a but under specified, its quite a complex set of variables to determine default HB, HB when not given and a user sets expiry etc. Do you have guidance here?
An earlier draft suggest expiry/2 with max 30s (iirc) but thats quite problematic with also 2 x HB being out. And in real life you should also consider network latency in waiting for HBs
Adding detail PR 176 js simplification ADR
piotrpio
force-pushed
the
js-simplification
branch
2 times, most recently
from
93ac978
to
8e74d60
Compare
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
…nd-design into js-simplification
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
js-simplification
branch
from
a5732d7
to
c32dd4b
Compare
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
This is the formalization of the JetStream simplification goals into the ADR. Some details still missing on the options but drawing the line in the sand.