Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-28: RePub, Fix typo in JSON fragment example #230

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

tbeets
Copy link
Contributor

@tbeets tbeets commented Jun 27, 2023

The JSON fragment example has "headers_only": "false" in example which fails API validation (2.10-Dev). Should be "headers_only": false.

Added an Updates to ADR-28 section to track.

… JSON validation error in API call against 2.10-Dev.
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 9949a74 into main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants