Add compression to object store #264
Conversation
This commit also cleans up formatting of the spec. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
adr/ADR-20.md
Outdated
|
|
||
| ```go | ||
| type ObjectInfo struct { | ||
| ObjectMeta | ||
|
|
There was a problem hiding this comment.
not sure these spaces are desired, also below and above
There was a problem hiding this comment.
Those spaces were removed in this PR, not added (by markdown linter). I have no idea why you would want them here, but the docs renders the same.
There was a problem hiding this comment.
oh god, need more coffee sorry, thought you were adding them lol.
There was a problem hiding this comment.
Right I see whats happening, you're removing spaces fine - but I think the entire line should be removed.
There was a problem hiding this comment.
Yeah, you're right, removed them entirely.
It was just linter cleaning things up. I didn't want to change more than required for this PR, as I will cleanup the ADR as follow up :).
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
|
@ripienaar the verbiage was compied from KV ADR PR, but I realized it was improved as a follow up :). Improved it a bit. |
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
This commit also cleans up formatting of the spec.