Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] ADR-6 note _kv prefix for key name is reserved #78

Merged
merged 5 commits into from
Dec 10, 2021

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Dec 8, 2021

No description provided.

@scottf scottf requested a review from ripienaar December 8, 2021 17:55
@scottf scottf mentioned this pull request Dec 8, 2021
15 tasks
adr/ADR-6.md Outdated Show resolved Hide resolved
@scottf scottf requested review from aricart and tbeets December 9, 2021 17:28
@scottf scottf changed the title [change] ADR-6 add colon to limited term to expand what is allowed for kv key name [change] ADR-6 note _kv prefix for key name is reserved Dec 9, 2021
Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scottf scottf merged commit 95c96d3 into main Dec 10, 2021
@scottf scottf deleted the update-kv-key-definition branch December 10, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants