Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bind stream JS option #95

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Support bind stream JS option #95

merged 2 commits into from
Nov 16, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Nov 16, 2023

add support to consume from streams that use sources:

connect: [
  {
      type: "JetStreamToKafka",
      brokers: ["127.0.0.1:9092"]
      id: "Telemetry",
      topic: "nats.telemetry",
      subject: "foo.*",
      durablename: "KafkaBridgeConsumer",
      stream: foo_global # Stream that is composed of many streams.
  },
],

Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (91ae479) 66.39% compared to head (6c3badc) 66.42%.

❗ Current head 6c3badc differs from pull request most recent head d873ee1. Consider uploading reports for the commit d873ee1 to get more accurate results

Files Patch % Lines
server/core/jetstream2kafka.go 0.00% 1 Missing ⚠️
server/core/kafka2jetstream.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   66.39%   66.42%   +0.03%     
==========================================
  Files          28       28              
  Lines        1821     1823       +2     
==========================================
+ Hits         1209     1211       +2     
  Misses        482      482              
  Partials      130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit b03b11e into main Nov 16, 2023
5 of 6 checks passed
@wallyqs wallyqs deleted the support-bind-stream branch November 16, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants