change service port name to support Istio explicit protocol selection #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes has a native construct for this called `appProtocol`. Kubernetes expects either a IANA protocol or a custom protocol prefix with a domain. I tried setting `appProtocol` to `nats.io/client` but that does not effect in Istio, as istio expects only these protocols: https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection Setting `appProtocol` to `tcp` probably does work, but tcp is not a valid iana service name. See: https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml Therefor the least intrusive, compatible leaves us with prefixing the service port name. Fixes: #88
|
hi, sorry for postmortem post, but is this fix needed for tcp/6222 server port as well? |
|
Typically no... As running NATS inside the istio-mesh may break other things also... but it could not hurt If I understand correctly 6222 is only used from server to server. And I think most people will run NATS outside the istio-mesh as you run into other problems as well when you run it inside the mesh. As 4222 can be called from a pod inside the istio-mesh, you need the explicit protocol selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes has a native construct for this called
appProtocol. Kubernetesexpects either a IANA protocol or a custom protocol prefix with a domain.
I tried setting
appProtocoltonats.io/clientbut that does not effectanything Istio, as istio expects only these protocols:
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
Setting
appProtocoltotcpprobably does work, but tcp is not a validiana service name. See:
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml
Therefor the least intrusive, compatible leaves us with prefixing the service
port name.
Fixes: #88