Add delivery thread per async subscriber #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation means that multiple subscribers are not able to process messages in parallel so causing head of line blocking issues among each other. Now each async subscriber has its own thread for message delivery in order to avoid this and follow similar usage as in the Go client.
wallyqs
changed the title
wallyqs
force-pushed
the
thread-per-async-sub
branch
from
28151d4
to
fb48c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation means that multiple subscribers are not able to process messages in parallel so causing head of line blocking issues among each other.
Now each async subscriber has its own thread and a sized queue for message delivery in order to avoid this, following similar usage as in the Go client where a goroutine is used per Subscription.