New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] experimental API pull
with max_bytes
returns only first message
#3816
Comments
@Jarema possible to take a look? |
yes. Will take look. |
One consideration before we go in a loop on this is that while the idea of having a request that only has
If that is the case, requests may not require the number of messages but they may specify them anyway. This means that the API should allow specifying |
So - on further elucidating, the issue is really that a |
Two thiggs I'm doing:
WIthout nr 1, clients cannot rely on |
Do we want/need these for a 2.9.12 release? |
I think we should revise this within the scope of v2.10 and not as the patch release from next week. |
Yes, that is definitely not for the patch. |
Fixed via #3822 |
Defect
Given a consumer that has 100 pending messages:
Doing a pull request like this:
Will yield a single message from the server. The server will not finalize the request, and no heartbeats are sent. The client will fail because of missed heartbeats. If
batch
is set to something, ie1000
- the request will succeed, heartbeat properly and send the finalization message telling how many bytes/messages are pending before the expiration.This happens all the way from 2.9.4 including current dev (2.11.x)
Steps or code to reproduce the issue:
Sample program to exercise this:
https://github.com/aricart/js-simplification-examples/blob/main/max_bytes_issue.ts
Expected result:
The 100 messages should have been delivered and the protocol messages signaling a heartbeat and completion of the request should have been returned to the client.
The text was updated successfully, but these errors were encountered: