Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of expired certificates in Windows Certificate Store #4383

Open
dmpriso opened this issue Aug 9, 2023 · 1 comment · May be fixed by #4384
Open

Handling of expired certificates in Windows Certificate Store #4383

dmpriso opened this issue Aug 9, 2023 · 1 comment · May be fixed by #4384
Assignees
Labels
proposal Enhancement idea or proposal

Comments

@dmpriso
Copy link

dmpriso commented Aug 9, 2023

Feature Request

Previously started here: #2130 (comment)

Use Case:

A typical windows server often already contains TLS certificates in the certificate store which have however expired.
The current NATS configuration only allows for matching a subject or an issuer of the certificate, so nothing unique (like a hash), and it also doesn't care about certificate validity

Proposed Change:

Add an option to skip expired certificate when searching for a match in the certificate store

Who Benefits From The Change(s)?

  • Administrators configuring NATS server instances

Alternative Approaches

Add another configuration option for searching for a certificate hash.

@tbeets
Copy link
Contributor

tbeets commented Aug 9, 2023

Makes sense to allow Windows repeated search until no more hits or a time valid cert (whichever first). Thanks for the contribution @dmpriso . I will review the PR.

@bruth bruth added proposal Enhancement idea or proposal and removed 🎉 enhancement labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants