Changing the subscription subject from a hard-coded value #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions in 'nats-client-dev.md' provide a command line argument of 'foo.' However, 'foo' was hard-coded. Now it will subscribe to the subject provided by the argument, and will default to 'foo'
kozlovic
requested changes
Feb 15, 2017
| "runtime" | ||
|
|
||
| "github.com/nats-io/go-nats" | ||
| ) | ||
| "github.com/nats-io/nats" |
There was a problem hiding this comment.
This needs to be go-nats, not nats
|
|
||
| // Keep the connection alive | ||
| runtime.Goexit() | ||
| } |
There was a problem hiding this comment.
Add a new line and please do:
gofmt -w async-sub.go
to get proper go formatting.
| } | ||
| // Create server connection: auth and no auth | ||
| // natsConnection, _ := nats.Connect("nats://foo:bar@localhost:4222") | ||
| natsConnection, _ := nats.Connect(nats.DefaultURL) |
There was a problem hiding this comment.
Not to your making, but not checking for error here is a bit wrong because if user forgets to run the NATS Server, this program will not complain but will not receive any message. Hopefully, the sender program will complain about not being able to connect ;-)
|
@Guitarbum722 I'm going to cancel this request. I've opened a new PR #210 to include your fix and @kozlovic feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions in
nats-client-dev.mdprovide a command line argument offoo. However,foowas hard-coded. Now it will subscribe to the subject provided by the argument, and will default tofoo.