Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tests "localhost" to "127.0.0.1" #1032

Merged
merged 1 commit into from Apr 2, 2020

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Apr 2, 2020

This may help speed up some Windows test in case "localhost" would
cause an attempt to connect to ::1 before failing back to 127.0.0.1.

Also update .travis.yml based on warnings displayed on the UI.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

This may help speed up some Windows test in case "localhost" would
cause an attempt to connect to ::1 before failing back to 127.0.0.1.

Also update .travis.yml based on warnings displayed on the UI.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 91.794% when pulling 4c973bd on change_localhost_to_loopback into 29f2f83 on master.

@kozlovic kozlovic merged commit a40dd6d into master Apr 2, 2020
@kozlovic kozlovic deleted the change_localhost_to_loopback branch April 2, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants