server: Bump to hashicorp/raft@v1.1.2 #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package raft has a breaking change in version v1.1.2 and uses the hclog.Logger interface instead of the stdlib log.Logger. This fixes that and allow nats-streaming-server to uses raft v1.1.2.
kozlovic
requested changes
Jun 5, 2020
go.sum
Outdated
| @@ -33,6 +33,8 @@ github.com/hashicorp/golang-lru v0.5.0 h1:CL2msUPvZTLb5O648aiLNJw3hnBxN2+1Jq8rCO | |||
| github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8= | |||
| github.com/hashicorp/raft v1.1.1 h1:HJr7UE1x/JrJSc9Oy6aDBHtNHUUBHjcQjTgvUVihoZs= | |||
| github.com/hashicorp/raft v1.1.1/go.mod h1:vPAJM8Asw6u8LxC3eJCUZmRP/E4QmUGE1R7g7k8sG/8= | |||
There was a problem hiding this comment.
I think a go mod tidy would have got rid of the ref to v1.1.1, no?
There was a problem hiding this comment.
Ran and pushed after a go mod tidy
| return newNATSTransportWithLogger(id, conn, timeout, log.New(logOutput, "", log.LstdFlags)) | ||
| logger := hclog.New(&hclog.LoggerOptions{ | ||
| Name: natsLogAppName, | ||
| Level: hclog.Debug, |
There was a problem hiding this comment.
I would have set, set it to Trace, we do suppress according to streaming's debug/trace level, but I then realize that clustering.go's (rl *raftLogger) Write() is not looking for trace, so that is ok for now. I will see if I add trace level later.
kozlovic
approved these changes
Jun 7, 2020
kozlovic
added a commit
that referenced
this pull request
Jun 22, 2020
This was added to git incorrectly with PR #1056 [ci skip] Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package raft has a breaking change in version v1.1.2 and uses the
hclog.Logger interface instead of the stdlib log.Logger. This fixes that
and allow nats-streaming-server to uses raft v1.1.2.