Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Clustering: possible panic with RAFT transport #1167

Merged
merged 1 commit into from Mar 2, 2021

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Mar 2, 2021

If there was a partial and what was in the pending buffer is less
than the size of the caller's buffer in Read(), we would get a
panic.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@coveralls
Copy link

coveralls commented Mar 2, 2021

Coverage Status

Coverage decreased (-0.1%) to 91.568% when pulling a62ba13 on cluster_fix_transport_panic into bb8246c on master.

If there was a partial and what was in the pending buffer is less
than the size of the caller's buffer in Read(), we would get a
panic.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic force-pushed the cluster_fix_transport_panic branch from 984d27c to a62ba13 Compare March 2, 2021 18:36
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 0b54427 into master Mar 2, 2021
@kozlovic kozlovic deleted the cluster_fix_transport_panic branch March 2, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants