[FIXED] Clustering: possible slow consumer errors #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in v0.21.0 when I moved to sync subscriptions and missed the fact that the pending limits do not apply to those type of subscriptions. Switching to async sub and adding buffers to a pending list. These are consumed in the Read() call made by the RAFT library. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
| next *pendingBuf | ||
| } | ||
|
|
||
| var pendingBufPool = &sync.Pool{ |
There was a problem hiding this comment.
I see you use these, they help?
There was a problem hiding this comment.
Honestly, with tests I have done, not really. But I have been using some in SQL code, etc..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in v0.21.0 when I moved to sync subscriptions
and missed the fact that the pending limits do not apply to those
type of subscriptions.
Switching to async sub and adding buffers to a pending list.
These are consumed in the Read() call made by the RAFT library.
Signed-off-by: Ivan Kozlovic ivan@synadia.com