[FIXED] Clustering: possible wrong pending_count and is_stalled on followers #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowers If a queue member receives a message and does not ack it within the AckWait interval, this message may be redelivered to a different member. If the original member then acknowledge the message, the server finds it in the other member and remove it from the pending list. This would cause the second member to show a wrong pending_count and possibly is_stalled values in monitoring of the followers. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
A change in v0.10.1 caused failed Close() to keep the underlying NATS connection opened, which would cause some tests to fail because the NATS connection would reconnect to subsequent tests, etc.. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a queue member receives a message and does not ack it within
the AckWait interval, this message may be redelivered to a different
member. If the original member then acknowledge the message, the
server finds it in the other member and remove it from the pending
list. This would cause the second member to show a wrong pending_count
and possibly is_stalled values in monitoring of the followers.
Signed-off-by: Ivan Kozlovic ivan@synadia.com