Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] RAFT subscriptions leak in failed connect #1257

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[FIXED] RAFT subscriptions leak in failed connect #1257

merged 1 commit into from
Jul 6, 2022

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Jul 6, 2022

Resolves #1256

Signed-off-by: Ivan Kozlovic ivan@synadia.com

@kozlovic
[FIXED] RAFT subscriptions leak in failed connect
f36eb36 
Resolves #1256

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
derekcollison approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nit on EMPTY vs "" but you can ignore if that is not the practice here.

server/raft_transport.go Show resolved Hide resolved
server/raft_transport.go Show resolved Hide resolved
@kozlovic kozlovic merged commit 3520b47 into main Jul 6, 2022
@kozlovic kozlovic deleted the fix_1256 branch July 6, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory increase in nats-streaming-server.exe on clusters with bad network connection
2 participants
@kozlovic @derekcollison