Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Clustering: should not start if streaming but no raft state #498

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Mar 6, 2018

The raft state is persisted in a directory that is configurable
with --cluster_log_path, but otherwise defaults to the name
of the cluster.
If after restarting a node the raft store has been cleared (as it
could happen when you misconfigure a node using Docker by having
the raft store being created in the container and therefore not
surviving a restart), bad things can happen: a node could elect
itself leader although it should not, or be unable to rejoin the
cluster. Also, the discrepancy between the streaming store and
raft store could cause other issues such as panic dealing with
the message store.

Resolves #497

@kozlovic kozlovic force-pushed the no_raft_but_streaming_stores branch from 62507c5 to 426debc Compare March 6, 2018 23:37
The raft state is persisted in a directory that is configurable
with `--cluster_log_path`, but otherwise defaults to the name
of the cluster.
If after restarting a node the raft store has been cleared (as it
could happen when you misconfigure a node using Docker by having
the raft store being created in the container and therefore not
surviving a restart), bad things can happen: a node could elect
itself leader although it should not, or be unable to rejoin the
cluster. Also, the discrepancy between the streaming store and
raft store could cause other issues such as panic dealing with
the message store.

Resolves #497
@kozlovic kozlovic force-pushed the no_raft_but_streaming_stores branch from 426debc to f1d080c Compare March 8, 2018 03:00
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.836% when pulling f1d080c on no_raft_but_streaming_stores into 68ec3c5 on master.

@kozlovic kozlovic merged commit 08c1b25 into master Mar 8, 2018
@kozlovic kozlovic deleted the no_raft_but_streaming_stores branch March 8, 2018 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants