Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] SQLStore: Unable to run against MySQL 8.0.2+ #538

Merged
merged 1 commit into from Mar 30, 2018
Merged

Conversation

kozlovic
Copy link
Member

This is due to the use of a now reserved word. Need to be escaped
with the "`" character. This character is used only for mysql
driver, not postgres (otherwise, it would break).

Resolves #536

This is due to the use of a now reserved word. Need to be escaped
with the "`" character. This character is used only for mysql
driver, not postgres (otherwise, it would break).

Resolves #536
@kozlovic
Copy link
Member Author

@camsjams Would really appreciate if you could try this fix with your MySQL 8.0.2 server. I have checked that it still works with 5.7 and also change still works with Postgres server. Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.806% when pulling 3b80e99 on fix_536 into 339bd7a on master.

@camsjams
Copy link
Contributor

Thanks for quick fix! I am having trouble installing the right Go version I think, tried 1.6.2 and 1.9.1 but caught up on just building the code - which version of Go are you running locally?

Once I can get a local build I will let you know.

@kozlovic
Copy link
Member Author

Running go 1.10, but you could use go 1.9.4. If you can let me know what issue exactly you have, I may be able to help you.
You may also find this useful: https://nats.io/documentation/streaming/nats-streaming-quickstart/
To get the branch with the fix, once you have cloned the repo, you would do

git checkout fix_536

Then you can build from there.

@camsjams
Copy link
Contributor

It was the path issue (namely where I did my git checkout relative to the $GOPATH).

Following https://nats.io/documentation/streaming/nats-streaming-quickstart/ and #248 helped me get the server running.

Now with go v1.10.0 and nats@nats-streaming-server#3b80e99a6698dc88f142b0ed75bb0cd27b4104de I can successfully use MySQL 8.0.2 - thanks!

@kozlovic
Copy link
Member Author

@camsjams Thanks for the confirmation, I am merging the PR then!

@kozlovic kozlovic merged commit 25e4194 into master Mar 30, 2018
@kozlovic kozlovic deleted the fix_536 branch March 30, 2018 19:32
kozlovic added a commit that referenced this pull request Dec 20, 2019
In #538 we
escaped `row` in the SQL code, but then this test does not have
it escaped. I recently updated my local MySQL server and got the
test failure.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants