Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Running server as a Windows Service #637

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

kozlovic
Copy link
Member

See README for details.

Also added option to specify a Windows Event Source name (--syslog_name),
which can be helpful if running more than one service on the same machine.

Resolves #632

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Resolves #632

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@nats-io nats-io deleted a comment from coveralls Aug 10, 2018
@sharkyfm
Copy link

Maybe at the start of the service it is better to write information about the server (ServerID, Go version, nats-server version and others) into one event, rather than individual events? 21 event looks uncomfortable.

@kozlovic
Copy link
Member Author

I understand your concerns, however, it is not possible to do this at this stage. The logger is passed to the Store and traces about channels being recovered are traced in the Store(s) implementations. Also, NATS Streaming Server may embed the NATS Server and actually uses the NATS Server log implementation and gives that to the NATS Server embedded code to trace NATS specific events.
It would require quite a bit of refactoring to be able to do just that: coalesce the startup/recovery traces into a single trace statement.

@sharkyfm
Copy link

Oh. I understood. Thanks for the work you've done. I think the functionality of the windows service will be very much not only for our company.
Ps: when is the release planned with this feature?

@kozlovic
Copy link
Member Author

@sharkyfm Maybe this week. Have you had a chance to try out this branch? I guess so since you reported on the logging behavior. Any other issue that you have found?

@sharkyfm
Copy link

Yes, I built this branch. The service is installed and uninstalled successfully, debug, trace and notice events are logged. Problems have not been found yet.

@kozlovic
Copy link
Member Author

Good to know. I will initiate the release likely today. Thanks!

@kozlovic kozlovic merged commit 02fec80 into master Aug 15, 2018
@kozlovic kozlovic deleted the run_as_windows_service branch August 15, 2018 14:42
kozlovic added a commit that referenced this pull request Aug 16, 2018
Bring changes from NATS Server master in.
This is related to #637

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic mentioned this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants