Added Close() for StanLogger to allow resources to be released #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the logger is file based, allow file to be closed for proper cleanup. This was found when running tests on Windows where test log could not be cleaned-up because the file was still opened. Also added some missing defers that would also cause some files to fail to be deleted on test exit. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the logger is file based, allow file to be closed for proper
cleanup. This was found when running tests on Windows where test
log could not be cleaned-up because the file was still opened.
Also added some missing defers that would also cause some files
to fail to be deleted on test exit.
Signed-off-by: Ivan Kozlovic ivan@synadia.com