[FIXED] Number of subscriptions in /serverz endpoint is incorrect #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of subscriptions was incorrectly increasing when a durable subscription was resumed. The proper behavior is as follows: - a durable is started for the first time, count increases - this durable is closed (but not unsubscribed), count unchanged - durable is unsubscribed, count decreases - a durable queue group is created, count increases - a member added, count increases - a member leaves, count decreases - the last member leaves (but group remains because durable), count is unchanged. - group is unsubscribed, count decreases. for non durable subscriptions (queue or not), when a subscription is created, count increases, when closed or unsubscribed, count decreases. Resolves #819 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
kozlovic
added a commit
that referenced
this pull request
May 6, 2019
Related to PR #820 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of subscriptions was incorrectly increasing when a durable
subscription was resumed.
The proper behavior is as follows:
is unchanged.
for non durable subscriptions (queue or not), when a subscription
is created, count increases, when closed or unsubscribed, count
decreases.
Resolves #819
Signed-off-by: Ivan Kozlovic ivan@synadia.com