Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snappy Compression #183

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Add Snappy Compression #183

merged 4 commits into from
Feb 6, 2024

Conversation

samuelattwood
Copy link
Member

No description provided.

Comment on lines -703 to -708
if err := json.Unmarshal(msg.Data, &r); err != nil {
return nil, err
}
r.Data = &d
if err := json.Unmarshal(msg.Data, &r); err != nil {
sc.logger.Warnf("Error deserializing JetStream info: %s", err)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this was a copy/paste oversight from getJSInfos

Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelattwood samuelattwood merged commit f065e97 into main Feb 6, 2024
2 checks passed
@samuelattwood samuelattwood deleted the sattwood/snappy-encoding branch February 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants